[GitHub] [spark] ivoson commented on a diff in pull request #36064: [SPARK-38108][SQL] Use error classes in the compilation errors of UDF/UDAF

[GitBox]

ivoson commented on code in PR #36064:
URL: https://github.com/apache/spark/pull/36064#discussion_r846607005


##########
sql/catalyst/src/main/scala/org/apache/spark/sql/errors/QueryCompilationErrors.scala:
##########
@@ -2310,16 +2297,22 @@ object QueryCompilationErrors {
   }
 
   def udfClassDoesNotImplementAnyUDFInterfaceError(className: String): 
Throwable = {
-    new AnalysisException(s"UDF class $className doesn't implement any UDF 
interface")
+    new AnalysisException(
+      errorClass = "UDF_CLASS_NOT_IMPLEMENT_ANY_UDF_INTERFACE",
+      messageParameters = Array(className))
   }
 
   def udfClassNotAllowedToImplementMultiUDFInterfacesError(className: String): 
Throwable = {
     new AnalysisException(
-      s"It is invalid to implement multiple UDF interfaces, UDF class 
$className")
+      errorClass = "UDF_CLASS_IMPLEMENT_MULTI_UDF_INTERFACE",
+      messageParameters = Array(className))
   }
 
   def udfClassWithTooManyTypeArgumentsError(n: Int): Throwable = {
-    new AnalysisException(s"UDF class with $n type arguments is not 
supported.")
+    new AnalysisException(
+      errorClass = "UNSUPPORTED_FEATURE",
+      messageParameters = Array(
+        s"UDF class with $n type arguments is not supported."))

Review Comment:
   Will fix.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org