Github user evacchi commented on a diff in the pull request:

    https://github.com/apache/spark/pull/6122#discussion_r30307278
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/SQLContext.scala ---
    @@ -1429,3 +1293,95 @@ class SQLContext(@transient val sparkContext: 
SparkContext)
     }
     
     
    +
    +/**
    + * :: DeveloperApi ::
    + * The primary workflow for executing relational queries using Spark.  
Designed to allow easy
    + * access to the intermediate phases of query execution for developers.
    + */
    +@DeveloperApi
    +protected[sql] class QueryExecution(val sqlContext: SQLContext, val 
logical: LogicalPlan) {
    --- End diff --
    
    It is `protected[sql]` in master. 
    
    BTW, this PR is geared towards making it easier for third parties (and 
HiveContext) to add new processing rules without requiring to subclass (see PR 
#5556 and [SPARK-6320](https://issues.apache.org/jira/browse/SPARK-6320)) 
    
    I would actually advise making these classes *public*


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to