HyukjinKwon commented on code in PR #36222: URL: https://github.com/apache/spark/pull/36222#discussion_r851818214
########## core/src/main/scala/org/apache/spark/rdd/HadoopRDD.scala: ########## @@ -457,9 +457,9 @@ private[spark] object HadoopRDD extends Logging { if (locationStr != "localhost") { if (loc.isInMemory) { logDebug(s"Partition $locationStr is cached by Hadoop.") - Some(HDFSCacheTaskLocation(locationStr).toString) + Option(HDFSCacheTaskLocation(locationStr).toString) } else { - Some(HostTaskLocation(locationStr).toString) + Option(HostTaskLocation(locationStr).toString) Review Comment: and this seems can't be `null` too because of `val hstr = str.stripPrefix(inMemoryLocationTag)` in the `apply`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org