[GitHub] [spark] beliefer commented on a diff in pull request #36330: [SPARK-38897][SQL]DS V2 supports push down string functions

[GitBox]

beliefer commented on code in PR #36330:
URL: https://github.com/apache/spark/pull/36330#discussion_r857076113


##########
sql/core/src/main/scala/org/apache/spark/sql/catalyst/util/V2ExpressionBuilder.scala:
##########
@@ -200,6 +200,49 @@ class V2ExpressionBuilder(
       } else {
         None
       }
+    case Substring(str, pos, len) =>
+      val s = generateExpression(str)
+      val p = generateExpression(pos)
+      val l = generateExpression(len)
+      if (s.isDefined && p.isDefined && l.isDefined) {
+        Some(new GeneralScalarExpression("SUBSTRING", 
Array[V2Expression](s.get, p.get, l.get)))
+      } else {
+        None
+      }
+    case Upper(child) => generateExpression(child)
+      .map(v => new GeneralScalarExpression("UPPER", Array[V2Expression](v)))
+    case Lower(child) => generateExpression(child)
+      .map(v => new GeneralScalarExpression("LOWER", Array[V2Expression](v)))
+    case StringTranslate(str, matching, replace) =>
+      val s = generateExpression(str)
+      val m = generateExpression(matching)
+      val r = generateExpression(replace)
+      if (s.isDefined && m.isDefined && r.isDefined) {
+        Some(new GeneralScalarExpression("TRANSLATE",
+          Array[V2Expression](s.get, m.get, r.get)))
+      } else {
+        None
+      }
+    case StringTrim(str, trim) =>
+      val s = generateExpression(str)
+      if (trim.isDefined) {
+        trim.flatMap(generateExpression(_)).map { t =>
+          new GeneralScalarExpression("TRIM", Array[V2Expression](s.get, t))
+        }
+      } else {
+        Some(new GeneralScalarExpression("TRIM", Array[V2Expression](s.get)))
+      }
+    case Overlay(input, replace, pos, len) =>
+      val i = generateExpression(input)
+      val r = generateExpression(replace)
+      val p = generateExpression(pos)
+      val l = generateExpression(len)
+      if (i.isDefined && r.isDefined && p.isDefined && l.isDefined) {
+        Some(new GeneralScalarExpression("OVERLAY",
+          Array[V2Expression](i.get, r.get, p.get, l.get)))
+      } else {
+        None
+      }

Review Comment:
   ```suggestion
        case overlay: Overlay =>
          val childrenExpressions = 
overlay.children.flatMap(generateExpression(_))
          if (childrenExpressions.length == wb.children.length) {
            Some(new GeneralScalarExpression("OVERLAY",
              childrenExpressions.toArray[V2Expression]))
          } else {
            None
          }
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org