beliefer commented on code in PR #36330:
URL: https://github.com/apache/spark/pull/36330#discussion_r857486955
##########
sql/catalyst/src/main/java/org/apache/spark/sql/connector/expressions/Trim.java:
##########
@@ -28,16 +28,26 @@
*/
@Evolving
public class Trim implements Expression, Serializable {
- private Expression[] children;
private String direction;
+ private Expression srcStr;
+ private Expression trimStr;
Review Comment:
Could you respect the order of parameters?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
