WangGuangxin commented on PR #36328: URL: https://github.com/apache/spark/pull/36328#issuecomment-1109584518
> Looks good to me overall. Do we need a test similar to this one [test("filter pushdown - StringStartsWith") ](https://github.com/apache/spark/blob/4c4e2c894eb515c87a90df6196bd51de65f38dba/sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetFilterSuite.scala#L1445) to make sure the the filters for `StringEndsWith` and `StringContains` are created and pushed down to Scan OK? done -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org