cloud-fan commented on code in PR #36330:
URL: https://github.com/apache/spark/pull/36330#discussion_r861505649
##########
sql/catalyst/src/main/java/org/apache/spark/sql/connector/util/V2ExpressionSQLBuilder.java:
##########
@@ -228,4 +241,37 @@ protected String visitSQLFunction(String funcName,
String[] inputs) {
protected String visitUnexpectedExpr(Expression expr) throws
IllegalArgumentException {
throw new IllegalArgumentException("Unexpected V2 expression: " + expr);
}
+
+ protected String visitOverlay(String[] inputs) {
+ if (inputs.length <= 3) {
+ return "OVERLAY(" + inputs[0] + " PLACING " + inputs[1] + " FROM " +
inputs[2] +")";
+ } else {
+ return "OVERLAY(" + inputs[0] + " PLACING " + inputs[1] + " FROM " +
inputs[2] +
+ " FOR " + inputs[3] +")";
+ }
+ }
+
+ protected String visitTrim(String[] inputs) {
Review Comment:
how about this
```
protected String visitTrim(String[] inputs, String direction) {
if (direction == "BOTH") ...
else if ...
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
