EnricoMi commented on code in PR #35965:
URL: https://github.com/apache/spark/pull/35965#discussion_r863144390
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/DataSourceV2ScanExecBase.scala:
##########
@@ -138,6 +138,12 @@ trait DataSourceV2ScanExecBase extends LeafExecNode {
}
}
+ override def outputOrdering: Seq[SortOrder] = scan match {
+ case s: SupportsReportOrdering if this.logicalLink.isDefined =>
Review Comment:
Alright, when partition grouping happens and multiple partitions are
grouped, ordering cannot be preserved.
I have modified `outputOrdering` not to return the ordering in that case.
Making grouped partitions preserve order is out-of-scope of this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
