cloud-fan commented on code in PR #36438:
URL: https://github.com/apache/spark/pull/36438#discussion_r866837234
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/adaptive/AdaptiveSparkPlanExec.scala:
##########
@@ -134,7 +134,8 @@ case class AdaptiveSparkPlanExec(
CoalesceShufflePartitions(context.session),
// `OptimizeShuffleWithLocalRead` needs to make use of
'AQEShuffleReadExec.partitionSpecs'
// added by `CoalesceShufflePartitions`, and must be executed after it.
- OptimizeShuffleWithLocalRead
+ OptimizeShuffleWithLocalRead,
+ PropagateEmptyPartitions
Review Comment:
shall we run it before `CoalesceShufflePartitions`? otherwise, some empty
partitions are coalesced and we are not able to detect them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
