sadikovi commented on code in PR #36427:
URL: https://github.com/apache/spark/pull/36427#discussion_r867751155
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetSchemaConverter.scala:
##########
@@ -174,9 +174,15 @@ class ParquetToSparkSchemaConverter(
*/
def convertField(
field: ColumnIO,
- sparkReadType: Option[DataType] = None): ParquetColumn = field match {
- case primitiveColumn: PrimitiveColumnIO =>
convertPrimitiveField(primitiveColumn, sparkReadType)
- case groupColumn: GroupColumnIO => convertGroupField(groupColumn,
sparkReadType)
+ sparkReadType: Option[DataType] = None): ParquetColumn = {
+ val targetType = sparkReadType.map {
Review Comment:
I added TestArrayUDT type which represents Array[Long] internally in
ParquetQuerySuite. Do you think I should add a more elaborate test with complex
types there?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
