xinrong-databricks commented on code in PR #36452: URL: https://github.com/apache/spark/pull/36452#discussion_r868581909
########## python/pyspark/pandas/groupby.py: ########## @@ -2673,7 +2682,7 @@ def get_group(self, name: Union[Name, List[Name]]) -> FrameLike: return self._cleanup_and_return(DataFrame(internal)) - def median(self, numeric_only: bool = True, accuracy: int = 10000) -> FrameLike: + def median(self, numeric_only: Optional[bool] = True, accuracy: int = 10000) -> FrameLike: Review Comment: Sorry I edited the explanation for SeriesGroupBy. Let me know if you have other concerns :). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org