cloud-fan commented on code in PR #36586:
URL: https://github.com/apache/spark/pull/36586#discussion_r875383064
##########
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/catalog/ExternalCatalogSuite.scala:
##########
@@ -1025,9 +1025,14 @@ abstract class CatalogTestUtils {
def newTable(name: String, db: String): CatalogTable = newTable(name,
Some(db))
+ def newTable(name: String, db: String, catalog: String): CatalogTable = {
Review Comment:
this won't be accepted by OSS as they use n-part name. Can we just use a
single `String` and parse it later?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
