dongjoon-hyun commented on code in PR #36597:
URL: https://github.com/apache/spark/pull/36597#discussion_r876457322
##########
core/src/main/scala/org/apache/spark/internal/config/History.scala:
##########
@@ -41,6 +41,15 @@ private[spark] object History {
.timeConf(TimeUnit.SECONDS)
.createWithDefaultString("10s")
+ val UPDATE_BATCHSIZE = ConfigBuilder("spark.history.fs.update.batchSize")
+ .doc("Specifies the batch size for updating new eventlog files. " +
+ "This controls each scan process to be completed within a reasonable
time, and such " +
+ "prevent the initial scan from running too long and blocking new
eventlog files to " +
+ "be scanned in time in large environments.")
+ .version("3.4.0")
+ .intConf
Review Comment:
We need a validation. IIUC, this should be positive to be valid. Do you have
any other validity check logic?
```scala
.checkValue(s => s > 0, "The batch size should be positive")
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
