HyukjinKwon commented on code in PR #36589:
URL: https://github.com/apache/spark/pull/36589#discussion_r877653141
##########
python/pyspark/sql/tests/test_streaming.py:
##########
@@ -592,6 +592,18 @@ def collectBatch(df, id):
if q:
q.stop()
+ def test_streaming_foreachBatch_graceful_stop(self):
+ # SPARK-39218: Make foreachBatch streaming query stop gracefully
+ def func(batch_df, _):
+ time.sleep(10)
Review Comment:
Yeah, that should work too.
##########
python/pyspark/sql/tests/test_streaming.py:
##########
@@ -592,6 +592,18 @@ def collectBatch(df, id):
if q:
q.stop()
+ def test_streaming_foreachBatch_graceful_stop(self):
+ # SPARK-39218: Make foreachBatch streaming query stop gracefully
+ def func(batch_df, _):
+ time.sleep(10)
Review Comment:
Let me fix 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
