gengliangwang commented on code in PR #36475: URL: https://github.com/apache/spark/pull/36475#discussion_r878740116
########## sql/core/src/test/scala/org/apache/spark/sql/execution/command/PlanResolutionSuite.scala: ########## @@ -1024,6 +1025,9 @@ class PlanResolutionSuite extends AnalysisTest { val sql7 = s"UPDATE defaultvalues SET i=DEFAULT, s=DEFAULT" val sql8 = s"UPDATE $tblName SET name='Robert', age=32 WHERE p=DEFAULT" val sql9 = s"UPDATE defaultvalues2 SET i=DEFAULT" + // Note: 'i' is the correct column name, but since the table has ACCEPT_ANY_SCHEMA capability, + // DEFAULT column resolution should skip this table. + val sql10 = s"UPDATE v2TableWithAcceptAnySchemaCapability SET i=DEFAULT" Review Comment: A better test case is to test a table with two columns (i & j) that accept any schema. On inserting i, even the column j has a default value, only column i is inserted. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org