cloud-fan commented on code in PR #36586:
URL: https://github.com/apache/spark/pull/36586#discussion_r879230753
##########
sql/core/src/main/scala/org/apache/spark/sql/internal/CatalogImpl.scala:
##########
@@ -125,6 +135,31 @@ class CatalogImpl(sparkSession: SparkSession) extends
Catalog {
isTemporary = isTemp)
}
+ private def makeTable(ident: Seq[String]): Table = {
+ val plan = UnresolvedTableOrView(ident, "Catalog.listTables", true)
+ val node = sparkSession.sessionState.executePlan(plan).analyzed
+ node match {
+ case t: ResolvedTable =>
+ val isExternal = t.table.properties().getOrDefault("external",
"false").equals("true")
+ new Table(
+ name = t.identifier.name(),
+ database = t.identifier.namespace().head,
+ description = t.table.properties().get("comment"),
+ tableType =
+ if (isExternal) CatalogTableType.EXTERNAL.name
+ else CatalogTableType.MANAGED.name,
+ isTemporary = false)
+ case v: ResolvedView =>
+ new Table(
Review Comment:
if `qualifier.length > 2`, it's a new code path and I don't know what to
report as a "database name". NULL seems reasonable here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
