cloud-fan commented on code in PR #36698: URL: https://github.com/apache/spark/pull/36698#discussion_r884489135
########## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/arithmetic.scala: ########## @@ -323,11 +389,24 @@ case class Add( override def decimalMethod: String = "$plus" + override def decimalType(p1: Int, s1: Int, p2: Int, s2: Int): DecimalType = { Review Comment: we should copy the doc from `DecimalPrecision` to here for the ADD opration. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org