cloud-fan commented on code in PR #36593: URL: https://github.com/apache/spark/pull/36593#discussion_r884875139
########## sql/catalyst/src/main/java/org/apache/spark/sql/connector/expressions/aggregate/UserDefinedAggregateFunc.java: ########## @@ -0,0 +1,67 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.spark.sql.connector.expressions.aggregate; + +import java.util.Arrays; +import java.util.stream.Collectors; + +import org.apache.spark.annotation.Evolving; +import org.apache.spark.sql.connector.expressions.Expression; + +/** + * The general representation of user defined aggregate function, which implements + * {@link AggregateFunc}, contains the upper-cased function name, the `isDistinct` flag and + * all the inputs. Note that Spark cannot push down partial aggregate with this function to + * the source, but can only push down the entire aggregate. + * + * @since 3.4.0 + */ +@Evolving +public class UserDefinedAggregateFunc implements AggregateFunc { + private final String name; + private String canonicalName; + private final boolean isDistinct; + private final Expression[] children; + + public UserDefinedAggregateFunc( + String name, String canonicalName, boolean isDistinct, Expression[] children) { + this.name = name; + this.canonicalName = canonicalName; + this.isDistinct = isDistinct; + this.children = children; + } + + public String name() { return name; } + public String canonicalName() { return canonicalName; } + public boolean isDistinct() { return isDistinct; } + + @Override + public Expression[] children() { return children; } + + @Override + public String toString() { + String inputsString = Arrays.stream(children) Review Comment: can we use `V2ExpressionSQLBuilder`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
