cloud-fan commented on code in PR #36698: URL: https://github.com/apache/spark/pull/36698#discussion_r885213632
########## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/DecimalPrecision.scala: ########## @@ -57,10 +53,13 @@ import org.apache.spark.sql.types._ * - LONG gets turned into DECIMAL(20, 0) * - FLOAT and DOUBLE cause fixed-length decimals to turn into DOUBLE * - Literals INT and LONG get turned into DECIMAL with the precision strictly needed by the value + * + * Note that, after SPARK-39316 all binary decimal arithmetic expressions report decimal type in Review Comment: instead of adding a note, can we just remove unrelated content (binary arithmetic) from the classdoc? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
