LucaCanali commented on code in PR #36662:
URL: https://github.com/apache/spark/pull/36662#discussion_r890504556
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala:
##########
@@ -2504,9 +2504,10 @@ object Decode {
usage = """
_FUNC_(bin, charset) - Decodes the first argument using the second
argument character set.
- _FUNC_(expr, search, result [, search, result ] ... [, default]) - Decode
compares expr
- to each search value one by one. If expr is equal to a search, returns
the corresponding result.
- If no match is found, then Oracle returns default. If default is
omitted, returns null.
+ _FUNC_(expr, search, result [, search, result ] ... [, default]) -
Compares expr
+ to each search value in order. If expr is equal to a search value,
_FUNC_ returns
+ the corresponding result. If no match is found, then it returns default.
If default
Review Comment:
I believe "returns" needs a subject to complete the sentence. One option is
to have "it" as proposed, other options are possible , for example repeating
_FUNC_ , or more options I guess.
The proposed change of just using "returns default", is quite
understandable, although strictly speaking is missing the subject.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
