gengliangwang commented on code in PR #36745:
URL: https://github.com/apache/spark/pull/36745#discussion_r891067965
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala:
##########
@@ -2881,6 +2881,15 @@ object SQLConf {
.booleanConf
.createWithDefault(true)
+ val DEFAULT_COLUMN_ALLOWED_PROVIDERS =
+ buildConf("spark.sql.defaultColumn.allowedProviders")
+ .internal()
+ .doc("List of table providers wherein SQL commands are permitted to
assign DEFAULT column " +
+ "values. Comma-separated list, whitespace ignored, case-insensitive.")
+ .version("3.4.0")
+ .stringConf
+ .createWithDefault("csv,json,orc,parquet")
Review Comment:
If the default column support of one data source has a bug, users can set
this conf to ban the data source. Probably we will need this conf and data
source API support?
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala:
##########
@@ -2881,6 +2881,15 @@ object SQLConf {
.booleanConf
.createWithDefault(true)
+ val DEFAULT_COLUMN_ALLOWED_PROVIDERS =
+ buildConf("spark.sql.defaultColumn.allowedProviders")
+ .internal()
+ .doc("List of table providers wherein SQL commands are permitted to
assign DEFAULT column " +
+ "values. Comma-separated list, whitespace ignored, case-insensitive.")
+ .version("3.4.0")
+ .stringConf
+ .createWithDefault("csv,json,orc,parquet")
Review Comment:
If the default column support of one data source has a bug, users can set
this conf to ban the data source. Probably we will need both this conf and data
source API support?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
