EnricoMi commented on code in PR #36150: URL: https://github.com/apache/spark/pull/36150#discussion_r892374424
########## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercion.scala: ########## @@ -736,6 +737,24 @@ abstract class TypeCoercionBase { } } + /** + * Determines the value type of a [[Melt]]. + */ + object MeltCoercion extends Rule[LogicalPlan] { + override def apply(plan: LogicalPlan): LogicalPlan = + plan resolveOperators { + case m: Melt if m.values.nonEmpty && m.values.forall(_.resolved) && m.valueType.isEmpty => Review Comment: I think `m.values.forall(_.resolved)` is still needed, otherwise `if m.values.nonEmpty && !haveSameType(m.values.map(_.dataType))` could call this rule when `values` are not resolved and `m.values.map(_.dataType)` would throw an exception. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org