zhouyejoe commented on code in PR #35906: URL: https://github.com/apache/spark/pull/35906#discussion_r892920621
########## common/network-yarn/src/main/java/org/apache/spark/network/yarn/YarnShuffleService.java: ########## @@ -230,11 +241,14 @@ protected void serviceInit(Configuration externalConf) throws Exception { // when it comes back if (_recoveryPath != null) { registeredExecutorFile = initRecoveryDb(RECOVERY_FILE_NAME); + mergeManagerFile = initRecoveryDb(SPARK_SHUFFLE_MERGE_RECOVERY_FILE_NAME); } - TransportConf transportConf = new TransportConf("shuffle", new HadoopConfigProvider(_conf)); - MergedShuffleFileManager shuffleMergeManager = newMergedShuffleFileManagerInstance( - transportConf); + TransportConf transportConf = new TransportConf("shuffle",new HadoopConfigProvider(_conf)); + if (shuffleMergeManager == null) { Review Comment: The main reason is that we have to set the customized MergeShuffleManager, and after the set, it shouldn't create the original shuffleMergeManager again here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org