chenzhx commented on code in PR #36663: URL: https://github.com/apache/spark/pull/36663#discussion_r893141595
########## sql/catalyst/src/main/java/org/apache/spark/sql/connector/expressions/GeneralScalarExpression.java: ########## @@ -196,6 +196,90 @@ * <li>Since version: 3.4.0</li> * </ul> * </li> + * <li>Name: <code>DATE_ADD</code> + * <ul> + * <li>SQL semantic: <code>DATE_ADD(start_date, num_days)</code></li> + * <li>Since version: 3.4.0</li> + * </ul> + * </li> + * <li>Name: <code>DATE_DIFF</code> + * <ul> + * <li>SQL semantic: <code>DATE_DIFF(end_date, start_date)</code></li> + * <li>Since version: 3.4.0</li> + * </ul> + * </li> + * <li>Name: <code>TRUNC</code> + * <ul> + * <li>SQL semantic: <code>TRUNC(date, format)</code></li> + * <li>Since version: 3.4.0</li> + * </ul> + * </li> + * <li>Name: <code>SECOND</code> + * <ul> + * <li>SQL semantic: <code>SECOND(timestamp, timezone)</code></li> + * <li>Since version: 3.4.0</li> + * </ul> + * </li> + * <li>Name: <code>MINUTE</code> + * <ul> + * <li>SQL semantic: <code>MINUTE(timestamp, timezone)</code></li> + * <li>Since version: 3.4.0</li> + * </ul> + * </li> + * <li>Name: <code>HOUR</code> + * <ul> + * <li>SQL semantic: <code>HOUR(timestamp, timezone)</code></li> + * <li>Since version: 3.4.0</li> + * </ul> + * </li> + * <li>Name: <code>MONTH</code> Review Comment: Yes. In some databases these field extractions are deprecated and EXTRACT is used instead, such as H2. http://h2database.com/html/functions.html#month -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org