BryanCutler commented on code in PR #36683: URL: https://github.com/apache/spark/pull/36683#discussion_r893770401
########## python/pyspark/sql/pandas/conversion.py: ########## @@ -596,7 +596,7 @@ def _create_from_pandas_with_arrow( ] # Slice the DataFrame to be batched - step = -(-len(pdf) // self.sparkContext.defaultParallelism) # round int up + step = self._jconf.arrowMaxRecordsPerBatch() Review Comment: I believe it was like this to create the same number of partitions as when arrow is disabled, although that might have changed since. If the DataFrame is split with `arrowMaxRecordsPerBatch` and a user wanted to create a certain number of partitions, then would they have to look at the size of the input and then adjust `arrowMaxRecordsPerBatch` accordingly? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org