ivoson commented on code in PR #36716: URL: https://github.com/apache/spark/pull/36716#discussion_r894409531
########## core/src/main/scala/org/apache/spark/deploy/master/ExecutorResourceDescription.scala: ########## @@ -0,0 +1,32 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.spark.deploy.master + +import org.apache.spark.resource.ResourceRequirement + +/** + * Describe resource requests for different resource profiles. Used for executor schedule. + * + * @param coresPerExecutor cores for each executor. + * @param memoryMbPerExecutor memory for each executor. + * @param customResourcesPerExecutor custom resource requests for each executor. Review Comment: done ########## core/src/main/scala/org/apache/spark/deploy/ApplicationDescription.scala: ########## @@ -19,23 +19,28 @@ package org.apache.spark.deploy import java.net.URI -import org.apache.spark.resource.ResourceRequirement +import org.apache.spark.resource.{ResourceProfile, ResourceRequirement, ResourceUtils} +import org.apache.spark.resource.ResourceProfile.getCustomExecutorResources private[spark] case class ApplicationDescription( name: String, maxCores: Option[Int], - memoryPerExecutorMB: Int, command: Command, appUiUrl: String, + defaultProfile: ResourceProfile, eventLogDir: Option[URI] = None, // short name of compression codec used when writing event logs, if any (e.g. lzf) eventLogCodec: Option[String] = None, - coresPerExecutor: Option[Int] = None, // number of executors this application wants to start with, // only used if dynamic allocation is enabled initialExecutorLimit: Option[Int] = None, - user: String = System.getProperty("user.name", "<unknown>"), - resourceReqsPerExecutor: Seq[ResourceRequirement] = Seq.empty) { + user: String = System.getProperty("user.name", "<unknown>")) { + + def memoryPerExecutorMB: Int = defaultProfile.getExecutorMemory.map(_.toInt).getOrElse(1024) + def coresPerExecutor: Option[Int] = defaultProfile.getExecutorCores + def resourceReqsPerExecutor: Seq[ResourceRequirement] = + ResourceUtils.executorResourceRequestToRequirement( + getCustomExecutorResources(defaultProfile).values.toSeq.sortBy(_.resourceName)) Review Comment: done -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
