cloud-fan commented on code in PR #36564:
URL: https://github.com/apache/spark/pull/36564#discussion_r894636200
##########
core/src/test/scala/org/apache/spark/scheduler/OutputCommitCoordinatorSuite.scala:
##########
@@ -289,6 +289,7 @@ private case class OutputCommitFunctions(tempDirPath:
String) {
// Mock output committer that simulates a failed commit (after commit is
authorized)
private def failingOutputCommitter = new FakeOutputCommitter {
override def commitTask(taskAttemptContext: TaskAttemptContext): Unit = {
+ super.commitTask(taskAttemptContext)
Review Comment:
I'm a bit worried about changing the behavior for the existing testing
output committer. Can we create a new one for the new test case?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
