weixiuli commented on code in PR #36162: URL: https://github.com/apache/spark/pull/36162#discussion_r895280301
########## core/src/main/scala/org/apache/spark/scheduler/TaskSchedulerImpl.scala: ########## @@ -863,6 +872,29 @@ private[spark] class TaskSchedulerImpl( executorUpdates) } + private def getTaskAccumulableInfosAndProgressRate( + updates: Seq[AccumulatorV2[_, _]]): (Seq[AccumulableInfo], Double) = { + var records = 0L + var runTime = 0L + val accInfos = updates.map { acc => + if (efficientTaskCalcualtionEnabled && acc.name.isDefined) { + val name = acc.name.get + if (name == shuffleRead.RECORDS_READ || name == input.RECORDS_READ) { + records += acc.value.asInstanceOf[Long] + } else if (name == InternalAccumulator.EXECUTOR_RUN_TIME) { + runTime = acc.value.asInstanceOf[Long] Review Comment: It's not easy to reuse, rigth ? Because this is map and other is foreach. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org