cloud-fan commented on code in PR #36740:
URL: https://github.com/apache/spark/pull/36740#discussion_r896290278


##########
sql/core/src/test/scala/org/apache/spark/sql/SubquerySuite.scala:
##########
@@ -2176,4 +2176,32 @@ class SubquerySuite extends QueryTest with 
SharedSparkSession with AdaptiveSpark
       }
     }
   }
+
+  test("SPARK-39355: Avoid UnresolvedAttribute.apply throwing ParseException") 
{
+    checkAnswer(
+      sql("""
+            |SELECT *

Review Comment:
   I think we should fix `Alias.toAttribute`. It should create an attribute to 
reference the output of this alias, which is a single column, and we need to 
use `UnresolvedAttribute.quoted`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to