viirya commented on code in PR #36809: URL: https://github.com/apache/spark/pull/36809#discussion_r898640889
########## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala: ########## @@ -4345,32 +4340,42 @@ object ApplyCharTypePadding extends Rule[LogicalPlan] { } /** - * Removes all [[TempResolvedColumn]]s in the query plan. This is the last resort, in case some - * rules in the main resolution batch miss to remove [[TempResolvedColumn]]s. We should run this - * rule right after the main resolution batch. + * The rule `ResolveAggregationFunctions` in the main resolution batch creates + * [[TempResolvedColumn]] in filter conditions and sort expressions to hold the temporarily resolved + * column with `agg.child`. When filter conditions or sort expressions are resolved, + * `ResolveAggregationFunctions` will turn [[TempResolvedColumn]] to [[AttributeReference]] if it's + * inside aggregate functions or group expressions, or turn it to [[UnresolvedAttribute]] otherwise, + * hoping other rules can resolve it. + * + * This rule runs after the main resolution batch, and can still hit [[TempResolvedColumn]] if + * filter conditions or sort expressions are not resolved. When this happens, there is no point to Review Comment: So you mean if `TempResolvedColumn` is inside filter conditions or sort expressions and these expressions are resolved, `TempResolvedColumn` will be replaced with `AttributeReference`. If the filter conditions or sort expressions are not resolved, `TempResolvedColumn` are remaining here. Is it correct? What `TempResolvedColumn` will be replaced with `UnresolvedAttribute`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org