dtenedor commented on code in PR #36771: URL: https://github.com/apache/spark/pull/36771#discussion_r899211242
########## sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/V2SessionCatalog.scala: ########## @@ -43,6 +43,8 @@ class V2SessionCatalog(catalog: SessionCatalog) extends TableCatalog with FunctionCatalog with SupportsNamespaces with SQLConfHelper { import V2SessionCatalog._ + var defaultColumnAnalyzer: Analyzer = null Review Comment: @gengliangwang Now that the refactoring PR is merged, I synced it into this PR and committed the change. This PR is now much simpler and ready for your review again, thank you for suggesting that ideas. ########## sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/V2SessionCatalog.scala: ########## @@ -43,6 +43,8 @@ class V2SessionCatalog(catalog: SessionCatalog) extends TableCatalog with FunctionCatalog with SupportsNamespaces with SQLConfHelper { import V2SessionCatalog._ + var defaultColumnAnalyzer: Analyzer = null Review Comment: @gengliangwang Now that the refactoring PR is merged, I synced it into this PR and committed the change. This PR is now much simpler and ready for your review again, thank you for suggesting that idea. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org