cloud-fan commented on code in PR #36773: URL: https://github.com/apache/spark/pull/36773#discussion_r902356266
########## sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSourceStrategy.scala: ########## @@ -750,6 +750,22 @@ object DataSourceStrategy PushableColumnWithoutNestedColumn(right), _) => Some(new GeneralAggregateFunc("CORR", agg.isDistinct, Array(FieldReference.column(left), FieldReference.column(right)))) + case aggregate.RegrIntercept(PushableColumnWithoutNestedColumn(left), + PushableColumnWithoutNestedColumn(right)) => + Some(new GeneralAggregateFunc("REGR_INTERCEPT", agg.isDistinct, + Array(FieldReference.column(left), FieldReference.column(right)))) + case aggregate.RegrR2(PushableColumnWithoutNestedColumn(left), Review Comment: not only this PR, but why can't we use `PushableExpression`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org