cloud-fan commented on code in PR #36946: URL: https://github.com/apache/spark/pull/36946#discussion_r904039714
########## sql/core/src/test/scala/org/apache/spark/sql/execution/command/v2/DescribeTableSuite.scala: ########## @@ -74,11 +54,11 @@ class DescribeTableSuite extends command.DescribeTableSuiteBase with CommandSuit QueryTest.checkAnswer( descriptionDf, Seq( - Row("id", "bigint", ""), - Row("data", "string", ""), - Row("", "", ""), - Row("# Partitioning", "", ""), - Row("Part 0", "id", ""), + Row("id", "bigint", null), + Row("data", "string", null), + Row("# Partition Information", "", ""), + Row("# col_name", "data_type", "comment"), + Row("id", "bigint", null), Review Comment: I see, can we at least include `Table Type` in v2 command? It's simply checking if the table has a reserved `EXTERNAL` table property. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org