gengliangwang commented on code in PR #36778:
URL: https://github.com/apache/spark/pull/36778#discussion_r904530629
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/connector/catalog/CatalogV2Util.scala:
##########
@@ -203,6 +203,14 @@ private[sql] object CatalogV2Util {
})
}
+ case update: UpdateColumnDefaultValue =>
+ replace(schema, update.fieldNames, field =>
+ if (update.newDefaultValue().nonEmpty) {
Review Comment:
Oh wait, it seems that will be "\"\""
Then when will the default value get cleared?
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/connector/catalog/CatalogV2Util.scala:
##########
@@ -203,6 +203,14 @@ private[sql] object CatalogV2Util {
})
}
+ case update: UpdateColumnDefaultValue =>
+ replace(schema, update.fieldNames, field =>
+ if (update.newDefaultValue().nonEmpty) {
Review Comment:
Oh wait, it seems that will be `"\"\""`
Then when will the default value get cleared?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
