Jonathancui123 commented on code in PR #36871:
URL: https://github.com/apache/spark/pull/36871#discussion_r905350901
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/csv/CSVInferSchema.scala:
##########
@@ -117,8 +123,19 @@ class CSVInferSchema(val options: CSVOptions) extends
Serializable {
case LongType => tryParseLong(field)
case _: DecimalType => tryParseDecimal(field)
case DoubleType => tryParseDouble(field)
- case TimestampNTZType => tryParseTimestampNTZ(field)
- case TimestampType => tryParseTimestamp(field)
+ case DateType => tryParseDateTime(field)
Review Comment:
I this change is necessary:
Consider the column of a TimestampType followed by a DateType entry. We
would expect this column to be inferred as a TimestampType column.
`typeSoFar` will be `Timestamp` when `inferField` is called on the second
entry which is DateType. We need logic in `inferField` to try and parse Date
type even when `typeSoFar` is `Timestamp`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
