Ngone51 commented on code in PR #37052:
URL: https://github.com/apache/spark/pull/37052#discussion_r914491973
##########
core/src/main/scala/org/apache/spark/storage/BlockManager.scala:
##########
@@ -526,16 +544,8 @@ private[spark] class BlockManager(
blockManagerId = if (idFromMaster != null) idFromMaster else id
- shuffleServerId = if (externalShuffleServiceEnabled) {
- logInfo(s"external shuffle service port = $externalShuffleServicePort")
- BlockManagerId(executorId, blockTransferService.hostName,
externalShuffleServicePort)
- } else {
- blockManagerId
- }
Review Comment:
This could be remained unchanged? If so, I think it's better to keep
`shuffleServerId` assignment in one place.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
