[GitHub] [spark] LuciferYang commented on a diff in pull request #37058: [SPARK-39661][SQL] Avoid creating unnecessary SLF4J Logger

[GitBox]

LuciferYang commented on code in PR #37058:
URL: https://github.com/apache/spark/pull/37058#discussion_r915841186


##########
common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/BlockStoreClient.java:
##########
@@ -42,7 +42,7 @@
  * or external service.
  */
 public abstract class BlockStoreClient implements Closeable {
-  protected final Logger logger = LoggerFactory.getLogger(this.getClass());
+  protected static final Logger logger = 
LoggerFactory.getLogger(BlockStoreClient.class);

Review Comment:
   @srowen Please don't merge this, I tested the timeout case locally use 
follow command:
   
   ```
   build/sbt "core/testOnly *BlockManagerBasicStrategyReplicationSuite"
   ```
   the test is really hang
   
   <img width="1195" alt="image" 
src="https://user-images.githubusercontent.com/1475305/177778662-e3051024-038e-4ea2-84a9-d8c2bdc65a66.png";>
   
   and I test this case in master, all passed.
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org