cloud-fan commented on code in PR #36150: URL: https://github.com/apache/spark/pull/36150#discussion_r919685963
########## core/src/main/resources/error/error-classes.json: ########## @@ -256,6 +256,18 @@ "Key <keyValue> does not exist. Use `try_element_at` to tolerate non-existent key and return NULL instead. If necessary set <config> to \"false\" to bypass this error." ] }, + "MELT_REQUIRES_VALUE_COLUMNS" : { Review Comment: I think the problem is which one should be the primary name? I'd vote for `unpivot` as it's a direct matching of the existing `pivot` feature in Spark. I'm OK to add `Dataset.melt` as an alias of `Dataset.unpivot` for Pandas compatibility. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org