goutam-git commented on code in PR #37065: URL: https://github.com/apache/spark/pull/37065#discussion_r932196681
########## sql/core/src/main/scala/org/apache/spark/sql/execution/columnar/compression/compressionSchemes.scala: ########## @@ -421,7 +421,7 @@ private[columnar] case object DictionaryEncoding extends CompressionScheme { override def compress(from: ByteBuffer, to: ByteBuffer): ByteBuffer = { if (overflow) { Review Comment: @MaxGekk should I remove the assert and use the new method name with error class instead of useDictionaryEncodingWhenDictionaryOverflowError() -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org