[GitHub] [spark] ueshin commented on a diff in pull request #37642: [SPARK-40202][PYTHON][SQL] Allow a dictionary in SparkSession.config in PySpark

Wed, 24 Aug 2022 11:17:46 -0700 


ueshin commented on code in PR #37642:
URL: https://github.com/apache/spark/pull/37642#discussion_r954135287


##########
python/pyspark/sql/session.py:
##########
@@ -202,6 +202,7 @@ def config(
             key: Optional[str] = None,
             value: Optional[Any] = None,
             conf: Optional[SparkConf] = None,
+            map: Optional[Dict[str, "OptionalPrimitiveType"]] = None,

Review Comment:
   nit: how about using keyword-only argument?
   
   ```py
               conf: Optional[SparkConf] = None,
               *,
               map: Optional[Dict[str, "OptionalPrimitiveType"]] = None,
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to