mridulm commented on code in PR #37843:
URL: https://github.com/apache/spark/pull/37843#discussion_r970393736
##########
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/v2/V2PredicateSuite.scala:
##########
@@ -287,7 +287,7 @@ class V2PredicateSuite extends SparkFunSuite {
new Predicate("=", Array[Expression](ref("a"), LiteralValue(1,
IntegerType))),
new Predicate("=", Array[Expression](ref("b"), LiteralValue(1,
IntegerType))))
assert(predicate1.equals(predicate2))
- assert(predicate1.references.map(_.describe()).toSeq == Seq("a", "b"))
+ assert(predicate1.references.map(_.describe()).toSeq.sorted == Seq("a",
"b"))
assert(predicate1.describe.equals("(a = 1) OR (b = 1)"))
Review Comment:
We are sure there is no ordering expected in the rest of the code right ?
Given this test, I want to make sure we are not missing anything (the test
could simply have been an artifact of existing sorted order ofcourse)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
