Github user hardmettle commented on a diff in the pull request:

    https://github.com/apache/spark/pull/6205#discussion_r30465539
  
    --- Diff: core/src/main/scala/org/apache/spark/rpc/akka/AkkaRpcEnv.scala ---
    @@ -212,7 +211,7 @@ private[spark] class AkkaRpcEnv private[akka] (
     
       override def asyncSetupEndpointRefByURI(uri: String): 
Future[RpcEndpointRef] = {
         import actorSystem.dispatcher
    -    actorSystem.actorSelection(uri).resolveOne(defaultLookupTimeout).
    +    
actorSystem.actorSelection(uri).resolveOne(defaultLookupTimeout.duration).
    --- End diff --
    
    If the return type changes from `Future[RpcEndpointRef]` to 
`RpcEndpointRef` then only the application of `Await.result` is possible else 
it will not be possible.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to