akpatnam25 commented on code in PR #37922:
URL: https://github.com/apache/spark/pull/37922#discussion_r977024406
##########
common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/ExternalBlockStoreClient.java:
##########
@@ -256,6 +256,20 @@ public void onFailure(Throwable e) {
}
}
+ @Override
+ public boolean removeShuffleMerge(String host, int port, int shuffleId) {
+ checkInit();
+ try {
+ TransportClient client = clientFactory.createClient(host, port);
Review Comment:
do we expect to take any action after sending this message via a callback?
If so we should consider using `sendRpc` instead of `send`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
