WeichenXu123 commented on code in PR #37918:
URL: https://github.com/apache/spark/pull/37918#discussion_r977291080
##########
sql/core/src/main/scala/org/apache/spark/sql/functions.scala:
##########
@@ -367,6 +367,9 @@ object functions {
*/
def collect_set(columnName: String): Column = collect_set(Column(columnName))
+ private[spark] def collect_top_k(e: Column, num: Int, reverse: Boolean):
Column =
Review Comment:
nit: shall we make it public ? It might be a useful function.
We don't need to do it in this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
