attilapiros commented on code in PR #37990:
URL: https://github.com/apache/spark/pull/37990#discussion_r979435775
##########
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/SparkKubernetesClientFactory.scala:
##########
@@ -115,7 +115,10 @@ private[spark] object SparkKubernetesClientFactory extends
Logging {
}
logDebug("Kubernetes client config: " +
new
ObjectMapper().writerWithDefaultPrettyPrinter().writeValueAsString(config))
- new
DefaultKubernetesClient(factoryWithCustomDispatcher.createHttpClient(config),
config)
+ new KubernetesClientBuilder()
Review Comment:
Because of
[apiimpl-split](https://github.com/fabric8io/kubernetes-client/blob/master/doc/MIGRATION-v6.md#apiimpl-split):
> When you rely solely on a compile dependency to the respective -api
dependencies you will not be able to use DefaultKubernetesClient nor
DefaultOpenShiftClient directly to create your client instances. You should
instead use KubernetesClientBuilder.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
