srowen commented on PR #37999: URL: https://github.com/apache/spark/pull/37999#issuecomment-1259433386
To be clear I was saying it _is already thread-safe_ but the issue could be lock contention. It may not be an issue in Spark, and/or fixed in Jackson, but I'm looking at posts like https://medium.com/feedzaitech/when-jackson-becomes-a-parallelism-bottleneck-f1440a50b429 I agree it doesn't look like there is evidence of contention here, so probably worth the perf improvement. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
