cloud-fan commented on code in PR #38004: URL: https://github.com/apache/spark/pull/38004#discussion_r982048790
########## sql/catalyst/src/main/scala/org/apache/spark/sql/connector/write/LogicalWriteInfoImpl.scala: ########## @@ -23,4 +23,6 @@ import org.apache.spark.sql.util.CaseInsensitiveStringMap private[sql] case class LogicalWriteInfoImpl( queryId: String, schema: StructType, - options: CaseInsensitiveStringMap) extends LogicalWriteInfo + options: CaseInsensitiveStringMap, + override val rowIdSchema: StructType = null, + override val metadataSchema: StructType = null) extends LogicalWriteInfo Review Comment: shall we make these two parameters optional as not every write needs to specify them? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org