Kimahriman commented on code in PR #38003:
URL: https://github.com/apache/spark/pull/38003#discussion_r989294323
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/FileScanBuilder.scala:
##########
@@ -70,8 +70,9 @@ abstract class FileScanBuilder(
}
override def pushFilters(filters: Seq[Expression]): Seq[Expression] = {
+ val (deterministicFilters, nonDeterminsticFilters) =
filters.partition(_.deterministic)
Review Comment:
Yes? Queries will fail if we don't filter things out from being partition
filters? Unless you don't care about the cases that fail and would rather allow
the cases that don't?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
