Github user dbtsai commented on a diff in the pull request:

    https://github.com/apache/spark/pull/6209#discussion_r30472396
  
    --- Diff: 
mllib/src/test/scala/org/apache/spark/mllib/linalg/BLASSuite.scala ---
    @@ -291,7 +319,7 @@ class BLASSuite extends FunSuite {
         val dATT = dAT.transpose
         val sATT = sAT.transpose
     
    -    assert(dATT.multiply(x) ~== expected absTol 1e-15)
    -    assert(sATT.multiply(x) ~== expected absTol 1e-15)
    +    assert(dATT.multiply(dx) ~== expected absTol 1e-15)
    +    assert(sATT.multiply(dx) ~== expected absTol 1e-15)
       }
    --- End diff --
    
    add
    ```
    assert(dATT.multiply(sx) ~== expected absTol 1e-15)
    assert(sATT.multiply(sx) ~== expected absTol 1e-15)
    ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to