mridulm opened a new pull request, #38378:
URL: https://github.com/apache/spark/pull/38378

   <!--
   Thanks for sending a pull request!  Here are some tips for you:
     4. Be sure to keep the PR description updated to reflect all changes.
     5. Please write your PR title to summarize what this PR proposes.
   -->
   
   ### What changes were proposed in this pull request?
   
   ##### Quick submission of drivers in tests to mesos scheduler results in 
dropping drivers
   
   Queued drivers in `MesosClusterScheduler` are ordered based on 
`MesosDriverDescription` - and the ordering used checks for priority (if 
different), followed by comparison of submission time.
   For two driver submissions with same priority, if made in quick succession 
(such that submission time is same due to millisecond granularity of Date), 
this results in dropping the second `MesosDriverDescription` from 
`queuedDrivers` (since `driverOrdering` returns `0` when comparing the 
descriptions).
   
   This PR fixes the more immediate issue with tests.
   
   ### Why are the changes needed?
   
   Flakey tests, [see 
here](https://lists.apache.org/thread/jof098qxp0s6qqmt9qwv52f9665b1pjg) for an 
example.
   
   ### Does this PR introduce _any_ user-facing change?
   
   No.
   Fixing only tests for now - as mesos support is deprecated, not changing 
scheduler itself to address this.
   
   ### How was this patch tested?
   
   Fixes unit tests


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to